Wed, Sep 26, 2007 at 11:05:33PM +0200, Bernhard Walle:
> * Oleg Verych <[email protected]> [2007-09-26 20:18]:
> > >
> > > --- a/kernel/kexec.c
> > > +++ b/kernel/kexec.c
> > > @@ -1172,33 +1172,50 @@ static int __init parse_crashkernel_mem(
> > > do {
> > > unsigned long long start = 0, end = ULLONG_MAX;
> > > unsigned long long size = -1;
> >
> > no need in assigning values here, unless you plan to use them in case
> > of `return -EINVAL', but i can not see that,
>
> What about this (and yes, I tested with some wrong strings with Qemu):
Reviewed-by: Oleg Verych <[email protected]>
Thanks :D
> ----
>
> This patch improves error handling in parse_crashkernel_mem() by comparing
> the return pointer of memparse() with the input pointer and also replaces
> all printk(KERN_WARNING msg) with pr_warning(msg).
>
>
> Signed-off-by: Bernhard Walle <[email protected]>
_____
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
