Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

["Ray Lee" <ray-lk@madrabbit.org>]

On 9/26/07, Brett Warden <brett.warden@gmail.com> wrote:
> Appeases the warning "parport0 (bw-qcam): use data_reverse for this!"
>
> Signed-off-by: Brett T. Warden <brett.warden@gmail.com>
>
> ---
>
> It seems to work fine with my Quickcam under 2.6.22.

> @@ -369,7 +374,11 @@ static void qc_reset(struct qcam_device *q)
>                         break;
>
>                 case QC_ANY:
> -                       write_lpcontrol(q, 0x20);
> +                       /*
> +                        * Replaced with reverse_port
> +                        * write_lpcontrol(q, 0x20);
> +                        */
> +                       reverse_port(q);
>                         write_lpdata(q, 0x75);
>
>                         if (read_lpdata(q) != 0x75) {

Just as an aside, if you've tested this and it works, then there's no
point to keep the write_lpcontrol even as a comment. Kill those four
lines, and if someone's interested in what happened they'll just look
at the file history.

Ray
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/