Re: missing mnt_drop_write() on open error

> > Btw, may_open() doesn't do mnt_want_write() around the truncation if
> > file is opened with O_TRUNC | O_RDONLY.
> 
> What's the path to may_open() in that case?  open_namei() should wrap
> all callers other than nfs, and it does:
> 
> 	/* O_TRUNC implies we need access checks for write permissions */
>         if (flag & O_TRUNC)
>                 acc_mode |= MAY_WRITE;
> 
> Which should trigger the may_open() code.  

Ah, I missed that.

Thanks,
Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • missing mnt_drop_write() on open error
    • From: Miklos Szeredi <[email protected]>
  • Re: missing mnt_drop_write() on open error
    • From: Dave Hansen <[email protected]>
  • Re: missing mnt_drop_write() on open error
    • From: Miklos Szeredi <[email protected]>
  • Re: missing mnt_drop_write() on open error
    • From: Dave Hansen <[email protected]>
  • Re: missing mnt_drop_write() on open error
    • From: Miklos Szeredi <[email protected]>
  • Re: missing mnt_drop_write() on open error
    • From: Dave Hansen <[email protected]>

• Prev by Date: dmapool
• Next by Date: [PATCH 1/4] Avoid taking waitqueue lock in dmapool
• Previous by thread: Re: missing mnt_drop_write() on open error
• Next by thread: [PATCH -mm] swap: fix function declaration
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]