Rusty Russell wrote: > On Tue, 2007-09-25 at 17:36 +0900, Tejun Heo wrote: >> Hmmm.... There doesn't seem to any reason why the blocking should be >> after calling ->exit(). And, yeah, it would be more useful and >> intuitive if blocking happens before ->exit(). What do you think? > > *That* I have no problem with. > > I was going to say "just grab a reference to every module" except if a > new module is loaded you don't know about it. > > If you move your blocking, it seems fine. Great, I think I was too occupied with the sysfs case when I was writing it. I'll update the patch. Thanks a lot. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: [email protected] (Jonathan Corbet)
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Tejun Heo <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Rusty Russell <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Tejun Heo <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Rusty Russell <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Tejun Heo <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Rusty Russell <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Tejun Heo <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Rusty Russell <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Tejun Heo <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Tejun Heo <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- From: Rusty Russell <[email protected]>
- Re: [PATCH 1/4] module: implement module_inhibit_unload()
- Prev by Date: Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)
- Next by Date: Re: 2.6.23-rc8-mm1, -rc7-mm1 kill audio on HP nx6325
- Previous by thread: Re: [PATCH 1/4] module: implement module_inhibit_unload()
- Next by thread: Re: [PATCH 1/4] module: implement module_inhibit_unload()
- Index(es):
 |