Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS

> Yup, I think I ditched most of them.. for some reason I decided it
> couldn't happen, but maybe I'm wrong ?

Well, it's a BUG_ON.  It's supposed to be for something that "can't happen".
That's why it's a sanity check, not a wild assertion. ;-)

The 2/2 patch is an example of a bug that CHECK_FULL_REGS catches.
In the status quo, using PTRACE_PEEKUSR in a bug case crashes while using
PTRACE_GETREGS in the same place might get bogus data.  (In the actual bug
thus found, the data is not bogus and only the bit that FULL_REGS checks is.)


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS
  - From: Benjamin Herrenschmidt <[email protected]>

References:
- [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS
  - From: Roland McGrath <[email protected]>
- Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS
  - From: Benjamin Herrenschmidt <[email protected]>

Prev by Date: Missing PCIe interface in lspci
Next by Date: Re: [PATCH] 2.6.22.6 user-mode linux: use address instead of value as argument in os_free_irq_by_cb
Previous by thread: Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS
Next by thread: Re: [PATCH 1/2] powerpc: ptrace CHECK_FULL_REGS
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]