Re: [PATCH 14/22] NFS: Use local caching

[Peter Staubach <staubach@redhat.com>]

David Howells wrote:
> David Howells <dhowells@redhat.com> wrote:
>
>   
> > Peter Staubach <staubach@redhat.com> wrote:
> >
> >     
> > > Did I miss the section where the modified semantics about which
> > > mounted file systems can use the cache and which ones can not
> > > was implemented?
> > >       
> > Yes.
> >     
>
> fs/nfs/super.c:
>
> 		case Opt_sharecache:
> 			mnt->flags &= ~NFS_MOUNT_UNSHARED;
> 			break;
> 		case Opt_nosharecache:
> 			mnt->flags |= NFS_MOUNT_UNSHARED;
> 			mnt->options &= ~NFS_OPTION_FSCACHE;
> 			break;
> 		case Opt_fscache:
> 			/* sharing is mandatory with fscache */
> 			mnt->options |= NFS_OPTION_FSCACHE;
> 			mnt->flags &= ~NFS_MOUNT_UNSHARED;
> 			break;
> 		case Opt_nofscache:
> 			mnt->options &= ~NFS_OPTION_FSCACHE;
> 			break;
>
> Hmmm...  Actually, I'm not sure this is sufficient.

This doesn't seem to take into account any of the other options
which can cause sharing to be disabled.  Perhaps SteveD can add
his patch to the mix which does resolve the issues?

   Thanx...

      ps
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/