Re: [patches] [PATCH] [13/50] x86: Fix and reenable CLFLUSH support inchange_page_attr()

>@@ -162,7 +198,7 @@ __change_page_attr(unsigned long address
> 	/* on x86-64 the direct mapping set at boot is not using 4k pages */
>  	BUG_ON(PageReserved(kpte_page));
> 
>-	save_page(kpte_page);
>+	save_page(kpte_page, 0);
> 	if (page_private(kpte_page) == 0)
> 		revert_page(address, ref_prot);
> 	return 0;

What is the point of continuing to launder kpte_page here? Page table pages
never get their caching attributes changed, nor would their direct mapping
ever change. (Same for i386, obviously.)

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] [0/50] x86 2.6.24 patches review II
    • From: Andi Kleen <[email protected]>
  • [PATCH] [13/50] x86: Fix and reenable CLFLUSH support in change_page_attr()
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH] Uninline kcalloc()
• Next by Date: Re: [PATCH] Move kasprintf.o to obj-y
• Previous by thread: Re: [PATCH] [13/50] x86: Fix and reenable CLFLUSH support in change_page_attr()
• Next by thread: [PATCH] [14/50] x86: Minor code-style cleanups to change_page_attr
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]