* Oleg Verych <[email protected]> [2007-09-23 01:14]:
> * Thu, 20 Sep 2007 19:18:46 +0200
>
> []
> > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4];
> > extern unsigned int vmcoreinfo_size;
> > extern unsigned int vmcoreinfo_max_size;
> > +int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
> > + unsigned long long *crash_size, unsigned long long *crash_base);
>
> (BTW, why `system_ram' is `unsigned long' in parse_crashkernel_mem() but
> `unsigned long long' in parse_crashkernel()?)
Because that's a bug, thanks for spotting that out. I will sent an
updated version of this patch until the issue below has been
clarified:
> What is the point of not using `ulong' and `u64'?
>
> What about another names?
>
> +int __init get_crashkernel_params(u64 *memsize, u64 *addrbase, char *cmdline, u64 ram);
Andrew, what's your opinion on this? Whould I resend the patch with
shorter type names?
Thanks,
Bernhard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
