Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

On Sat, Sep 22, 2007 at 12:34:31AM +0200, Andi Kleen wrote:
 > On Friday 21 September 2007 23:13, Dave Jones wrote:
 > > On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote:
 > >  > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also
 > >  > the stack can be already unaligned so letting the compiler align
 > >  > is useless. This may make some stack frames smaller.
 > >  > Only works with very recent gcc 4.3
 > >
 > > My gcc 4.1.2 from Fedora 7 (with who knows what backported)
 > > references this in its manpage. How was it broken before 4.3 ?
 > 
 > Try it. It is rejected by the compiler in 64bit mode.

Ah yes, it fails if not between 4 & 12, but the call cc-option
catches that.  Looks fine to me.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] [0/45] x86 2.6.24 patches review I
    • From: Andi Kleen <[email protected]>
  • [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible
    • From: Dave Jones <[email protected]>
  • Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v2
• Next by Date: Re: [PATCH 1/2] bnx2: factor out gzip unpacker
• Previous by thread: Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible
• Next by thread: Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]