Re: [PATCH] Re: Serial USB-driver for Winchiphead CH340/41 chip

[Werner Cornelius <Werner.Cornelius@cornelius-consult.de>]

Am Freitag, 21. September 2007 18:18 schrieb Greg KH:

Hello,

> On Fri, Sep 21, 2007 at 10:15:11AM +0200, Werner Cornelius wrote:
> > Hello,
> >
> > attached you will find the patch against the 2.6.23-rc6-mm1
> >
> > Changed fetaures:
> >
> > 1. All baudrates possible (dynamic baudfactor calculation)
> > 2. Added support of modem control and status lines.
>
> You forgot:
> 	3. broke all formatting

sorry about, but that wasn't an intend.
This action has been done by one or more of the apps I am using (editor, 
mailer...). I assume it is a feature of Kmail, inserting plane text seems to 
be converted to space separated text, discarding tabs.  

>
> :(
>
> Please redo the patch such that the formating of the file is not changed
> (you converted tabs to spaces).
>
> > --- linux-2.6.23-rc6-mm1/drivers/usb/serial/ch341.c	2007-09-21
> > 09:56:56.000000000 +0200
> > +++ develop/drivers/usb/serial/ch341.c	2007-09-21 10:00:26.000000000
> > +0200 @@ -1,5 +1,9 @@
> >  /*
> > - * Copyright 2007, Frank A Kingswood <frank@kingswood-consulting.co.uk>
> > + * Copyright 2007, Frank A Kingswood <frank <at>
> > kingswood-consulting.co.uk>
>
> Why did you change this email address?

This address was in the original file I got from the net. Perhaps this file 
have had spaces instead of tabs, too.

>
> > + *
> > + * Copyright 2007, Werner Cornelius <werner <at> cornelius-consult.de>
> > + * for changes/extenions regarding universal baud rate capability and
> > modem + * line control/status routines.
>
> Don't put changelog information in a copyright notice, that's not
> needed.  Just put your name there please, with a "real" email address.

Ok. that should be ok. I am not used to the rules on the kernel traffic list.

>
> And we need a "Signed-off-by:" line.

I did add one on last request.
Was this wrong ?
Perhaps I need an Howto about mailing to kernel list. I read the main 
documentation, but didn't found this amount of request rules in a way that 
would be sufficient to publish a patch which I just wanted to make useable by 
the whole community.
I will try to verify how I could generate the patch in a way that it might be 
acceptable.

>
> thanks,
>
> greg k-h

Werner
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/