Re: x86_64: potential critical issue with quicklists and page table pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, 21 Sep 2007, Siddha, Suresh B wrote:
>
> git commit 34feb2c83beb3bdf13535a36770f7e50b47ef299 started using quicklists
> for freeing page table pages and removed the usage of tlb_remove_page()
> 
> And looking at quicklist_free() and quicklist_free_page(), on a NUMA platform,
> this can potentially free the page before the corresponding TLB caches
> are flushed.

Hmm? We only add them to the quicklists in the exact same places where we 
*used* to just free them entirely. So I don't see why semantics would have 
changed..

> Can we revert this commit for 2.6.23 and look at this code post 2.6.23?

I'll happily revert it, but I want to understand this better, so more of 
an explanation of the codepath that actually does something wrong, please.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux