Re: [patch 2/5] VFS: pass open file to ->getattr()

On Sep 21, 2007  14:23 +0200, Miklos Szeredi wrote:
> @@ -1212,7 +1212,8 @@ struct inode_operations {
> -	int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *);
> +	int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *,
> +			struct file *file);

It's not much of an inode operation anymore if you need to pass a file
to it...  Since the attributes are really part of the inode and not
the file, this seems like a bit of a hack.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2/5] VFS: pass open file to ->getattr()
    • From: Miklos Szeredi <[email protected]>

• References:
  • [patch 0/5] VFS changes
    • From: Miklos Szeredi <[email protected]>
  • [patch 2/5] VFS: pass open file to ->getattr()
    • From: Miklos Szeredi <[email protected]>

• Prev by Date: Re: [PATCH 1/2] bnx2: factor out gzip unpacker
• Next by Date: Re: [patch 3/5] VFS: pass open file to ->xattr()
• Previous by thread: [patch 2/5] VFS: pass open file to ->getattr()
• Next by thread: Re: [patch 2/5] VFS: pass open file to ->getattr()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]