Re: [patch 1/4] Linux Kernel Markers - Architecture Independent Code

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Steven Rostedt (rostedt@goodmis.org) wrote:
> On Tue, Sep 18, 2007 at 05:13:25PM -0400, Mathieu Desnoyers wrote:
> > +/*
> > + * Sets the probe callback corresponding to one marker.
> > + */
> > +static int set_marker(struct marker_entry **entry,
> > +			struct __mark_marker *elem)
> > +{
> > +	int ret;
> > +	BUG_ON(strcmp((*entry)->name, elem->name) != 0);
> 
> Can you switch this at least to WARN_ON?  Killing a system with X
> running where the user just sees a freeze is not that nice. But a nasty
> message in dmesg is very noticable.
> 
Sure.

> -- Steve
> 
> > +
> > +	if ((*entry)->format) {
> > +		if (strcmp((*entry)->format, elem->format) != 0) {
> > +			printk(KERN_NOTICE
> > +				"Format mismatch for probe %s "
> > +				"(%s), marker (%s)\n",
> > +				(*entry)->name,
> > +				(*entry)->format,
> > +				elem->format);
> > +			return -EPERM;
> > +		}
> > +	} else {
> > +		ret = marker_set_format(entry, elem->format);
> > +		if (ret)
> > +			return ret;
> > +	}
> > +	elem->call = (*entry)->probe;
> > +	elem->pdata = (*entry)->pdata;
> > +	_immediate_set(elem->state, 1);
> > +	return 0;
> > +}

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/