Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote:
(from ecryptfs_encrypt_page()):
> > +	enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER);
> 
> I'd have thought that alloc_page() would be nicer.  After all, we _are_
> treating it as a page, and not as a random piece of memry.
>
> > +	if (!enc_extent_virt) {
> > +		rc = -ENOMEM;
> > +		ecryptfs_printk(KERN_ERR, "Error allocating memory for "
> > +				"encrypted extent\n");
> > +		goto out;
> > +	}
> > +	enc_extent_page = virt_to_page(enc_extent_virt);
> 
> And then we don't need this.

If neither kmap() nor kmap_atomic() can be safely used to get a
virtual address to pass to vfs_write(), then I do not know what my
other options are here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write
    • From: Erez Zadok <[email protected]>

• References:
  • [PATCH 0/11] eCryptfs: Introduce persistent lower files for each eCryptfs inode
    • From: Michael Halcrow <[email protected]>
  • [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write
    • From: Michael Halcrow <[email protected]>
  • Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: 2.6.23-rc6-mm1: failure to boot on HP nx6325, no sound when booted, USB-related WARNING
• Next by Date: Re: 2.6.23-rc6-mm1: failure to boot on HP nx6325, no sound when booted, USB-related WARNING
• Previous by thread: Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write
• Next by thread: Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]