On Wed, 2007-09-19 at 18:27 +0100, Christoph Hellwig wrote:
> > int permission(struct inode *inode, int mask, struct nameidata *nd)
> > {
> > int retval, submask;
> > + struct vfsmount *mnt = NULL;
> > +
> > + if (nd)
> > + mnt = nd->mnt;
> >
> > if (mask & MAY_WRITE) {
> > umode_t mode = inode->i_mode;
> > @@ -251,7 +255,7 @@ int permission(struct inode *inode, int
> > * MAY_EXEC on regular files is denied if the fs is mounted
> > * with the "noexec" flag.
> > */
> > - if (nd && nd->mnt && (nd->mnt->mnt_flags & MNT_NOEXEC))
> > + if (mnt && (mnt->mnt_flags & MNT_NOEXEC))
>
> Why is this entirely unrelated cleanup in this patch?
>
> Except for that it looks fine.
You're right. In this context, it looks completely unrelated. I'll
separate it into another patch.
-- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
