Re: error from checkpatch.pl version 0.10

[Satyam Sharma <satyam@infradead.org>]

On Thu, 20 Sep 2007, Tetsuo Handa wrote:
> 
> I checked my patch using checkpatch.pl version 0.10
> and I got the following error.
> 
>   ERROR: need consistent spacing around '*' (ctx:WxV)
>   #2334: FILE: security/tomoyo/common.c:2306:
>   +static unsigned int tmy_poll(struct file *file, poll_table *wait)
>                                                               ^

Looks like a checkpatch.pl bug to me -- that was nothing to warn about.


> What action should I take?
> Ignore this error because "poll_table" is used everywhere?
> Replace "poll_table" with "struct poll_table_struct" according to
> definition of "poll_table"?

Yeah, this would be better to do anyway (and rename poll_table_struct
to just poll_table).

>   typedef struct poll_table_struct {
>           poll_queue_proc qproc;
>   } poll_table;

So:

	struct poll_table {
		poll_queue_proc qproc;
	};

In general the kernel's codingstyle consensus is to avoid adding typedefs.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/