Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

Maciej W. Rozycki wrote:

 Remove typedefs, volatiles and convert kmalloc()/memset() pairs to
kcalloc().  Also reformat the surrounding clutter.

Signed-off-by: Maciej W. Rozycki <[email protected]>
---
On Thu, 13 Sep 2007, Jeff Garzik wrote:

Net driver patches should apply on top of netdev-2.6.git#upstream, which is
where changes to net drivers are queued for the next release.

I can see Andrew has done some changes to the patch and applied it anyway, but here's a version I generated against your tree. Please feel free to choose either.

You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the evening, but I will send you a fix shortly. To be honest I think even with bulk changes it may be worth checking whether they do not break stuff. ;-)

hrm. I cannot get this to apply on top of linux-2.6.git, netdev-2.6.git#upstream (prior to net-2.6.24 rebase) or netdev-2.6.git#upstream (after net-2.6.24 rebase)

ACK the changes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: "Maciej W. Rozycki" <[email protected]>

• References:
  • [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: Ralf Baechle <[email protected]>
  • Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
    • From: "Maciej W. Rozycki" <[email protected]>

• Prev by Date: Re: [PATCH] binfmt_flat: minimum support for theBlackfin relocations
• Next by Date: Re: [PATCH 3/3] CRED: Move the effective capabilities into the cred struct
• Previous by thread: Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
• Next by thread: Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]