Re: [PATCH] cafe_ccic: default to allocating DMA buffers at probe time

[corbet@lwn.net (Jonathan Corbet)]

Andres Salomon <dilinger@queued.net> wrote:

> This patch makes DMA buffer allocation happen during device probe by
> default, and changes the parameter to 'alloc_bufs_at_read'.  The
> camera hardware is there, if the cafe_ccic driver is enabled/loaded it
> should do its best to ensure that the camera is actually usable;
> delaying DMA buffer allocation saves an insignicant amount of memory,
> and causes the driver to be much less useful.

The amount of memory isn't quite "insignificant" (three 640x480x2
buffers), but the OLPC people clearly need things to work this way.
There are, as far as I know, no other systems out there using the CAFE
controller.  Making things work by default for the one user (with a fair
number of deployed systems!) makes sense to me.  So...

  Acked-by: Jonathan Corbet <corbet@lwn.net>

That said, I do prefer the original name for the parameter.

jon

Jonathan Corbet / LWN.net / corbet@lwn.net


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/