[PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Signed-off-by: Rene Herman <[email protected]>

Rene.

diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index f0cbcdb..670dd49 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
 		if (val & UCB_ADC_DAT_VALID)
 			break;
 		/* yield to other processes */
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(1);
+		schedule_timeout_uninterruptible(1);
 	}
 
 	return UCB_ADC_DAT_VALUE(val);

---

• Follow-Ups:
  • Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
    • From: Nicolas Pitre <[email protected]>

• Prev by Date: Re: Intel-Quad on GA-P35-S3 motherboard with 4*2GB
• Next by Date: [PATCH] PHYLIB: Spinlock fixes for softirqs
• Previous by thread: [PATCH] Consolidate sleeping routines in file locking code
• Next by thread: Re: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]