On Mon, Sep 17, 2007 at 12:29:51PM -0700, Mingming Cao wrote: > The problem with this patch, as Andreas Dilger pointed today in ext4 > interlock call, for 1k,2k block size ext2/3/4, get_free_pages() waste > 1/3-1/2 page space. > > What was the originally intention to set up slabs for committed_data(and > frozen_buffer) in JBD? Why not using kmalloc? kmalloc is using slabs :) The intent was to avoid the wasted memory, but as we've repeated a gazillion times wasted memory on a rather rare codepath doesn't really matter when you just crash random storage drivers otherwise. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Mingming Cao <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Lameter <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Lameter <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Lameter <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- [PATCH] JBD slab cleanups
- From: Mingming Cao <[email protected]>
- Re: [PATCH] JBD slab cleanups
- From: Mingming Cao <[email protected]>
- [RFC 1/2] JBD: slab management support for large block(>8k)
- Prev by Date: Re: [kvm-devel] [PATCH] Refactor hypercall infrastructure
- Next by Date: Re: [PATCH] 2.6.23-rc6: Fix NUMA Memory Policy Reference Counting
- Previous by thread: Re: [PATCH] JBD slab cleanups
- Next by thread: Re: [PATCH] JBD slab cleanups
- Index(es):