Re: [PATCH] modpost: detect unterminated device id lists

On Wed, 12 Sep 2007 17:49:37 -0700 Kees Cook <[email protected]> wrote:

> This patch against 2.6.23-rc6 will cause modpost to fail if any device
> id lists are incorrectly terminated, after reporting the offender.

I'm getting this:

rusb2/pvrusb2: struct usb_device_id is 20 bytes.  The last of 3 is:
0x03 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: drivers/media/video/pvrusb2/pvrusb2: struct usb_device_id is not terminated with a NULL entry!

("rusb2/pvrusb2" ??)

but:

struct usb_device_id pvr2_device_table[] = {
	[PVR2_HDW_TYPE_29XXX] = { USB_DEVICE(0x2040, 0x2900) },
	[PVR2_HDW_TYPE_24XXX] = { USB_DEVICE(0x2040, 0x2400) },
	{ USB_DEVICE(0, 0) },
};
	
looks OK?

Using plain old "{ }" shut the warning up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] modpost: detect unterminated device id lists
    • From: "Satyam Sharma" <[email protected]>

• References:
  • [PATCH] pci: fix unterminated pci_device_id lists
    • From: Kees Cook <[email protected]>
  • Re: [PATCH] pci: fix unterminated pci_device_id lists
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] pci: fix unterminated pci_device_id lists
    • From: "Alexey Dobriyan" <[email protected]>
  • Re: [PATCH] pci: fix unterminated pci_device_id lists
    • From: Greg KH <[email protected]>
  • [PATCH] modpost: detect unterminated device id lists
    • From: Kees Cook <[email protected]>

• Prev by Date: Re: [00/41] Large Blocksize Support V7 (adds memmap support)
• Next by Date: RE: Wasting our Freedom
• Previous by thread: Re: [PATCH] modpost: detect unterminated device id lists
• Next by thread: Re: [PATCH] modpost: detect unterminated device id lists
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]