Re: [patch] add some Blackfin specific checks to checkpatch.pl

["Mike Frysinger" <vapier.adi@gmail.com>]

On 9/13/07, Andy Whitcroft <apw@shadowen.org> wrote:
> On Tue, Aug 21, 2007 at 06:29:59PM -0400, Mike Frysinger wrote:
> > Check for a few common errors in Blackfin-specific code wrt MMR loading in
> > assembly and doing core/system syncs.
>
> If we are going to pull arch specific things into checkpatch I think we
> need to make sure we are pretty specific about where we apply them.  I
> am assuming these checks only make sense againt some files in the arch
> tree?

ive restricted the .S check to arch/blackfin/, but the other check
should be run on all .c files since Blackfin drivers may live anywhere
in the tree, not just in arch/ ... i really doubt that'd be a problem
unless another architecture starts implementing functions with
"__builtin_bfin_ssync" in its name ...

side note, Joe pointed out that arch/blackfin regex should be m@...@, not s@...@
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/