Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask

[mel@skynet.ie (Mel Gorman)]

On (12/09/07 14:23), Christoph Lameter didst pronounce:
> On Wed, 12 Sep 2007, Mel Gorman wrote:
> 
> > -			z++)
> > -		;
> > +	if (likely(nodes == NULL))
> > +		for (; zonelist_zone_idx(z) > highest_zoneidx;
> > +				z++)
> > +			;
> > +	else
> > +		for (; zonelist_zone_idx(z) > highest_zoneidx ||
> > +				(z->zone && !zref_in_nodemask(z, nodes));
> > +				z++)
> > +			;
> >  
> 
> Minor nitpick here: "for (;" should become "for ( ;" to have correct 
> whitespace. However, it would be clearer to use a while here.
> 
> while (zonelist_zone_idx(z)) > highest_zoneidx)
> 		z++;
> 
> etc.

Good point. I'll clean it up and retest. Thanks

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/