Re: [PATCH] Blackfin arch: add some missing syscall

[Paul Mundt <lethal@linux-sh.org>]

On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote:
> @@ -352,9 +353,54 @@
>  #define __NR_shmdt		340
>  #define __NR_shmget		341
>  
> -#define __NR_syscall		342
> +#define __NR_splice		342
> +#define __NR_sync_file_range	343
> +#define __NR_tee		344
> +#define __NR_vmsplice		345
> +
> +#define __NR_epoll_pwait	346
> +#define __NR_utimensat		347
> +#define __NR_signalfd		348
> +#define __NR_timerfd		349
> +#define __NR_eventfd		350
> +#define __NR_pread64		351
> +#define __NR_pwrite64		352
> +#define __NR_fadvise64		353
> +
> +#define __NR_syscall		354
>  #define NR_syscalls		__NR_syscall
>  
Err, why did you change __NR_syscall? This is going to break the ABI for
anything using it, which is generally bad form.

You also missed sys_fallocate(), another reason to be using git, rather
than some silly subversion tree ;-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/