* Randy Dunlap ([email protected]) wrote:
> On Thu, 06 Sep 2007 16:07:35 -0400 Mathieu Desnoyers wrote:
>
> [snip]
>
> > This patch:
> >
> > Add Kconfig menus for the marker code.
> >
> > [[email protected]: Never ever select MODULES]
> > Signed-off-by: Mathieu Desnoyers <[email protected]>
> > Reviewed-by: Christoph Hellwig <[email protected]>
> > Reviewed-by: "Frank Ch. Eigler" <[email protected]>
> > CC: Adrian Bunk <[email protected]>
> > ---
> >
> > arch/alpha/Kconfig | 2 ++
> > arch/arm/Kconfig | 2 ++
> > arch/avr32/Kconfig.debug | 7 +++++++
> > arch/cris/Kconfig | 2 ++
> > arch/frv/Kconfig | 2 ++
> > arch/h8300/Kconfig | 2 ++
> > arch/i386/Kconfig | 2 ++
> > arch/ia64/Kconfig | 2 ++
> > arch/m32r/Kconfig | 2 ++
> > arch/m68k/Kconfig | 2 ++
> > arch/m68knommu/Kconfig | 2 ++
> > arch/mips/Kconfig | 2 ++
> > arch/parisc/Kconfig | 2 ++
> > arch/powerpc/Kconfig | 2 ++
> > arch/ppc/Kconfig | 2 ++
> > arch/s390/Kconfig | 2 ++
> > arch/sh/Kconfig | 2 ++
> > arch/sh64/Kconfig | 2 ++
> > arch/sparc/Kconfig | 2 ++
> > arch/sparc64/Kconfig | 2 ++
> > arch/um/Kconfig | 2 ++
> > arch/v850/Kconfig | 2 ++
> > arch/x86_64/Kconfig | 2 ++
> > arch/xtensa/Kconfig | 2 ++
> > kernel/Kconfig.marker | 7 +++++++
> > kernel/Makefile | 1 +
> > 26 files changed, 61 insertions(+)
> >
> > Index: linux-2.6-lttng/arch/alpha/Kconfig
> > ===================================================================
> > --- linux-2.6-lttng.orig/arch/alpha/Kconfig 2007-09-04 12:14:48.000000000 -0400
> > +++ linux-2.6-lttng/arch/alpha/Kconfig 2007-09-04 12:16:57.000000000 -0400
> > @@ -646,6 +646,8 @@ config SRM_ENV
> >
> > source "fs/Kconfig.binfmt"
> >
> > +source "kernel/Kconfig.marker"
> > +
> > endmenu
> >
> > source "net/Kconfig"
> > Index: linux-2.6-lttng/kernel/Kconfig.marker
> > ===================================================================
> > --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> > +++ linux-2.6-lttng/kernel/Kconfig.marker 2007-09-04 12:16:57.000000000 -0400
> > @@ -0,0 +1,7 @@
> > +# Code markers configuration
> > +
> > +config MARKERS
> > + bool "Activate markers"
> > + help
> > + Place an empty function call at each marker site. Can be
> > + dynamically changed for a probe function.
> > Index: linux-2.6-lttng/arch/avr32/Kconfig.debug
> > ===================================================================
> > --- linux-2.6-lttng.orig/arch/avr32/Kconfig.debug 2007-09-04 12:14:49.000000000 -0400
> > +++ linux-2.6-lttng/arch/avr32/Kconfig.debug 2007-09-04 12:16:57.000000000 -0400
> > @@ -6,6 +6,9 @@ config TRACE_IRQFLAGS_SUPPORT
> >
> > source "lib/Kconfig.debug"
> >
> > +menu "Instrumentation Support"
> > + depends on EXPERIMENTAL
> > +
> > config KPROBES
> > bool "Kprobes"
> > depends on DEBUG_KERNEL
> > @@ -16,4 +19,8 @@ config KPROBES
> > for kernel debugging, non-intrusive instrumentation and testing.
> > If in doubt, say "N".
> >
> > +source "kernel/Kconfig.marker"
> > +
> > +endmenu
> > +
> > endmenu
>
> It seems sad that this patch sources Kconfig.marker, a 7-line file,
> 20-something times. Yes, you (we) don't want to put those 7 lines
> into 20-something different files, so sourcing is the right thing.
>
> However, what you did for avr32 seems more on the right track to me:
> make _one_ Instrumentation support menu that includes PROFILING,
> OPROFILE, KPROBES, and MARKERS and then use (source) that in all
> of the arches.
>
Ok, it will be in my next post.
Mathieu
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
