Re: [PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate

On Wednesday 12 September 2007, Michael Ellerman wrote:
> The spufs_coredump_read array is NULL terminated, and we also store the size.
> We only need one or the other, and storing the size should save a teensy bit
> of memory vs NULL terminating, so do that.

Given that we have another array in there with almost the same contents
and that is NULL terminated, I'd vote for doing it the other way and also
use NULL-termination instead of the count here.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 01/15] Extract the file descriptor search logic in SPU coredump code
    • From: Michael Ellerman <[email protected]>
  • [PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate
    • From: Michael Ellerman <[email protected]>

• Prev by Date: Re: [PATCH 09/15] Internal __spufs_get_foo() routines should take a spu_context *
• Next by Date: [PATCH] Fix hci_sock build with CONFIG_COMPAT=n
• Previous by thread: [PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate
• Next by thread: [PATCH 09/15] Internal __spufs_get_foo() routines should take a spu_context *
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]