On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: > This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around > DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get > routine for us. > > Unfortunately we need two get routines (a locked and unlocked version) to > support the coredump code. This patch hides one of those (the locked version) > inside the macro foo. > > Signed-off-by: Michael Ellerman <[email protected]> > --- > arch/powerpc/platforms/cell/spufs/file.c | 216 +++++++++++------------------- > 1 files changed, 76 insertions(+), 140 deletions(-) jk said: > "Good god man!" Yeah, I'm a bit lukewarm on this one. But the diffstat is nice, 50% code reduction ain't bad :) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()
- From: Arnd Bergmann <[email protected]>
- Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()
- References:
- [PATCH 01/15] Extract the file descriptor search logic in SPU coredump code
- From: Michael Ellerman <[email protected]>
- [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()
- From: Michael Ellerman <[email protected]>
- [PATCH 01/15] Extract the file descriptor search logic in SPU coredump code
- Prev by Date: stripping down the kernel-parameters.txt file
- Next by Date: Re: [Sparc64 BUG] hangup under booting 2.6.22.X whith Sparc64
- Previous by thread: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()
- Next by thread: Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()
- Index(es):
 |