Re: clockevents: fix resume logic

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 11 Sep 2007 08:37:16 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 2007-09-10 at 14:47 -0700, Andrew Morton wrote:
> > > 
> > >     clockevents: fix resume logic
> > >     
> > >     We need to make sure, that the clockevent devices are resumed, before
> > >     the tick is resumed. The current resume logic does not guarantee this.
> > >     
> > >     Add CLOCK_EVT_MODE_RESUME and call the set mode functions of the clock
> > >     event devices before resuming the tick / oneshot functionality.
> > >     
> > >     Fixup the existing users.
> > >     
> > >     Thanks to Nigel Cunningham for tracking down a long standing thinko,
> > >     which affected the jinxed VAIO.
> > >     
> > 
> > This patch broke the jinxed vaio.
> > 
> > Which is a bit odd, considering that I must have tested it at the time. 
> > But I bisected it right down to this commit, and the below revert patch
> > fixed it up.
> 
> I just looked up, that you confirmed earlier that the patch does _not_
> break the VAIO. 
> 
> I think, that some other suspend/resume/ACPI or whatever change went in
> before this patch got merged into Linus tree. Sigh. That's pretty hard
> to find out.
> 

I tried just 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 on top of 2.6.22
(threw away the lguest and xen hunks).  The same problem occurs.  2.6.22 is
OK.

I went back to the original patch which I sent to Linus and it matches
18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6.  So all I can think is that there
must have been something else in the tree which I tested which fixed the
bug which 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 introduced.  argh.

Can you think what would cause the symptoms which I described?  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/