Re: [patch 1/3] futex_compat: fix list traversal bugs

* [email protected] <[email protected]> wrote:

> The futex list traversal on the compat side appears to have a bug.
> 
> It's loop termination condition compares:
> 
>         while (compat_ptr(uentry) != &head->list)
> 
> But that can't be right because "uentry" has the special "pi" 
> indicator bit still potentially set at bit 0.  This is cleared by 
> fetch_robust_entry() into the "entry" return value.

hm. I remember having tested this - not well enough i guess :-/

Acked-by: Ingo Molnar <[email protected]>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/3] futex_compat fixes
    • From: [email protected]
  • [patch 1/3] futex_compat: fix list traversal bugs
    • From: [email protected]

• Prev by Date: Re: 2.6.23-rc4-mm1
• Next by Date: Re: [patch 2/3] futex_compat: simplify pointer magic
• Previous by thread: [patch 1/3] futex_compat: fix list traversal bugs
• Next by thread: [patch 2/3] futex_compat: simplify pointer magic
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]