Randy Dunlap wrote: > On Mon, 10 Sep 2007 16:12:58 +0200 Laurent Vivier wrote: > >> [PATCH 3/4] modify account_system_time() to add cputime to cpustat->guest if we >> are running a VCPU. We add this cputime to cpustat->user instead of >> cpustat->system because this part of KVM code is in fact user code although it >> is executed in the kernel. We duplicate VCPU time between guest and user to >> allow an unmodified "top(1)" to display correct value. A modified "top(1)" is >> able to display good cpu user time and cpu guest time by subtracting cpu guest >> time from cpu user time. Update "gtime" in task_struct accordingly. >> >> Signed-off-by: Laurent Vivier <[email protected]> > > > Hi, > Please use kernel-doc notation here: > (see Documentation/kernel-doc-nano-HOWTO.txt or source file examples > or ask) > > easy fix: > > /* > + * Account guest cpu time to a process. > > /** > * account_guest_time - Account guest cpu time to a process. > > + * @p: the process that the cpu time gets accounted to > + * @cputime: the cpu time spent in virtual machine since the last update > + */ > +void account_guest_time(struct task_struct *p, cputime_t cputime) > +{ thank you for the comment. But I just made a cut&past of the comment of the function above. Should I be consistent with the doc or with the source ? Laurent -- ------------- [email protected] -------------- "Software is hard" - Donald Knuth
Attachment:
signature.asc
Description: OpenPGP digital signature
- Follow-Ups:
- References:
- Prev by Date: [PATCH] UML - Fix ELF_CORE_COPY_REGS build botch
- Next by Date: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
- Previous by thread: Re: [RESEND 2][PATCH 3/4] modify account_system_time() to update guest time in cpustat and task_struct
- Next by thread: Re: [RESEND 2][PATCH 3/4] modify account_system_time() to update guest time in cpustat and task_struct
- Index(es):
 |