Avi Kivity wrote: > Ingo Molnar wrote: >> * Laurent Vivier <[email protected]> wrote: >> >> >>> Ingo, please, could you have a look to these patches ? >>> >>> The aim of these four patches is to introduce Virtual Machine time >>> accounting. >>> >>> [PATCH 1/4] as recent CPUs introduce a third running state, after >>> "user" and "system", we need a new field, "guest", in cpustat to >>> store the time used by the CPU to run virtual CPU. Modify /proc/stat >>> to display this new field. >>> >> >> the concept certainly looks sane to me. >> >> The heavy-handed use of #ifdefs uglifies the code to a large degree, >> but this is not a fundamental problem: since basically all distros >> have KVM enabled (and lguest benefits from this too), could you just >> make all this new code unconditional? >> > > I imagine the embedded people will complain... perhaps move all the code > to a #ifdef section above with a full implementation and a stub > implementation. > I'm going to repost patches without #ifdefs for readability. Then we could discuss if we should introduce #ifdefs and how. Laurent -- ------------- [email protected] -------------- "Software is hard" - Donald Knuth
Attachment:
signature.asc
Description: OpenPGP digital signature
- Follow-Ups:
- Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- From: Alistair John Strachan <[email protected]>
- Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- References:
- [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- From: Laurent Vivier <[email protected]>
- Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- From: Ingo Molnar <[email protected]>
- Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- From: Avi Kivity <[email protected]>
- [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- Prev by Date: [PATCH] x86: multi-byte single instruction NOPs
- Next by Date: Re: [PATCH] input: Fix interrupt enable in i8042_ctr when enabling interrupt fails
- Previous by thread: Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- Next by thread: Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
- Index(es):
 |