On Thu, 30 Aug 2007 16:13:55 +0100 (BST) The AmigaLinux A2232 Driver Project <[email protected]> wrote:
>
>
> This patch handles the case in which the request for the
> vertical blank interrupt could not be granted. Thanks to
> Nazia Zaman for spotting it.
>
> Applies to latest 2.6.x kernels.
>
>
> --- linux/drivers/char/ser_a2232.c.org 2007-08-30 15:41:25.000000000 +0100
> +++ linux/drivers/char/ser_a2232.c 2007-08-30 15:46:17.000000000 +0100
> @@ -787,7 +787,7 @@ static int __init a2232board_init(void)
>
> }
>
> - printk("Total: %d A2232 boards initialized.\n", nr_a2232); /* Some status report if no card was found */
> + printk("Total: %d A2232 boards detected.\n", nr_a2232); /* Some status report if no card was found */
>
> a2232_init_portstructs();
>
> @@ -795,9 +795,13 @@ static int __init a2232board_init(void)
> a2232_init_drivers also registers the drivers. Must be here because all boards
> have to be detected first.
> */
> - if (a2232_init_drivers()) return -ENODEV; // maybe we should use a different -Exxx?
> + if (a2232_init_drivers())
> + return -ENODEV; // maybe we should use a different -Exxx?
>
> - request_irq(IRQ_AMIGA_VERTB, a2232_vbl_inter, 0, "A2232 serial VBL", a2232_driver_ID);
> + if (request_irq(IRQ_AMIGA_VERTB, a2232_vbl_inter, 0, "A2232 serial VBL", a2232_driver_ID))
> + return -ENODEV;
We're going to need to undo the things which a2232_init_drivers() just did.
There's a memory leak and the registered tty driver might even cause a
crash if someone tries to use it?
Perhaps requesting the IRQ before running a2232_init_drivers() would be a
suitable approach.
> + printk("A2232 driver initialized successfully.\n");
> return 0;
> }
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
