* Ananth N Mavinakayanahalli ([email protected]) wrote:
> On Thu, Sep 06, 2007 at 04:01:30PM -0400, Mathieu Desnoyers wrote:
>
> <snip>
>
> > @@ -716,8 +720,9 @@ static int __kprobes pre_handler_kretpro
> > struct kretprobe_instance, uflist);
> > ri->rp = rp;
> > ri->task = current;
> > + kernel_text_lock();
> > arch_prepare_kretprobe(ri, regs);
> > -
> > + kernel_text_unlock();
>
> pre_handler_kretprobe() is run when the entry probe for a retprobed
> function is hit and cannot block. You can't take a mutex here.
>
> And why do we need to take the kernel_text_lock() here anyway? All
> arch_prepare_kretprobe() does is modify the return address stored either
> on stack or a register (arch specific) to the trampoline. We don't
> change any kernel text here.
>
Yep, good catch. Fixing.
> Ananth
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
