Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

/from the media. */
>  > +	if (qc->nbytes < 2048)
>  > +		return -EOPNOTSUPP;
>  > +
>  >  	/* No ATAPI DMA in smart mode */
>  >  	if (itdev->smart)
>  >  		return -EOPNOTSUPP;
>  > 
> 
> This looks like a gross hack. Aren't you supposed to inspect
> the command instead and whitelist the ones you know are OK,
> like pata_pdc2027x.c and sata_promise.c do?

It does seem to be about transfer size in the IT821x case not commands.
It may be to do with how we issue ATAPI command transfer sizes from high
up (patch went to Jeff) but for now this is definitely the right approach

Reviewed-by: Alan Cox <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
    • From: Tejun Heo <[email protected]>

• References:
  • [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
    • From: Jeff Norden <[email protected]>
  • Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
    • From: Mikael Pettersson <[email protected]>

• Prev by Date: Re: [PATCH 0/2] Fix (improve) deadlock condition on module removal netfilter socket option removal
• Next by Date: Re: ICH Intel PATA short cable override...
• Previous by thread: Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
• Next by thread: Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]