Re: [PATCH 0/2] Fix (improve) deadlock condition on module removal netfilter socket option removal

[Rusty Russell <rusty@rustcorp.com.au>]

On Wed, 2007-09-05 at 15:27 -0400, Neil Horman wrote:
> On Thu, Sep 06, 2007 at 03:41:37AM +1000, Rusty Russell wrote:
> > 	You have this backwards: O_NONBLOCK is the default.  That seems to be
> > what everyone wants, although I implemented 'rmmod -w' because it seemed
> > like a good option.
> > 
> Thats really the point I'm trying to make.  O_NONBLOCK should be the default,
> but it isn't in the case of modprobe.

Ouch, you're right!

And that's been around for a *long* time.  From the original 0.9.2
version (Dec 9th 2002).  ChangeLog says:

	Jim Radford <radford@blackbean.org>'s modprobe -r implementation.

The userspace check still stops most cases of removing used modules.

On the bright side, this one bug has probably done more to deprecate
module removal than any thing else, by making it unreliable...

Good catch!
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/