Re: [PATCH] slub - Use local_t protection

On Tue, 4 Sep 2007, Mathieu Desnoyers wrote:

> @@ -1566,12 +1565,13 @@ redo:
>  		object[c->offset]) != object))
>  			goto redo;
>  
> -	put_cpu();
> +	local_exit(flags);
>  	if (unlikely((gfpflags & __GFP_ZERO)))
>  		memset(object, 0, c->objsize);
>  
>  	return object;
>  slow:
> +	local_exit(flags);

Here we can be rescheduled to another processors.

>  	return __slab_alloc(s, gfpflags, node, addr, c)

c may point to the wrong processor.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] slub - Use local_t protection
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH] slub - Use local_t protection
    • From: Mathieu Desnoyers <[email protected]>
  • [PATCH] local_t protection (critical section)
    • From: Mathieu Desnoyers <[email protected]>

• References:
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [PATCH] SLUB use cmpxchg_local
    • From: Christoph Lameter <[email protected]>
  • [PATCH] slub - Use local_t protection
    • From: Mathieu Desnoyers <[email protected]>

• Prev by Date: Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd)
• Next by Date: What's happening with the cpuidle code?
• Previous by thread: [PATCH] slub - Use local_t protection
• Next by thread: [PATCH] local_t protection (critical section)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]