tir, 04 09 2007 kl. 13:06 +0200, skrev Jens Axboe: > On Tue, Sep 04 2007, Micah Gruber wrote: > > This patch fixes a potential null dereference bug where we dereference us before a null check. This patch simply moves the dereferencing after the null check. > > > > Signed-off-by: Micah Gruber <[email protected]> > > Be careful with stuff like that, if you actually look at the code, a us > == NULL doesn't seem to be possible (or usbat_flash_transport() would > have oopsed before). > If that is true, then if (!us) return USB_STOR_TRANSPORT_ERROR; is utterly pointless. Simon Holm Thøgersen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- From: Jens Axboe <[email protected]>
- Re: [linux-usb-devel] [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- From: Alan Stern <[email protected]>
- Re: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- References:
- [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- From: Micah Gruber <[email protected]>
- Re: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- From: Jens Axboe <[email protected]>
- [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- Prev by Date: [PATCH 0/2] Fix (improve) deadlock condition on module removal netfilter socket option removal
- Next by Date: [PATCH 1/2] Fix (improve) deadlock condition on module removal netfilter socket option removal
- Previous by thread: Re: [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- Next by thread: Re: [linux-usb-devel] [PATCH] Fix a potential NULL pointer dereference in usbat_check_status() in drivers/usb/storage/shuttle_usbat.c
- Index(es):
 |