Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote:
> 
> drivers/net/3c59x.c: In function 'vortex_up':
> drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function

This came in with the recently applied 3c59x-check-return-of-pci_enable_device patch
from Mark Hindley. I just compiled it on a PCI only machine so far, therefore I did
not notice the warning yet.

> 
> is a genuine bug. The function returns an uninitialized value of 'err'
> back to the caller, which expects it to be 0 for success cases. Let's
> fix this by explicitly initializing 'err' to zero.
> 
> Signed-off-by: Satyam Sharma <[email protected]>
Acked-by: Steffen Klassert <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug
    • From: Mark Hindley <[email protected]>
  • Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug
    • From: Satyam Sharma <[email protected]>

• References:
  • [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug
    • From: Satyam Sharma <[email protected]>

• Prev by Date: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c
• Next by Date: Re: [PATCH] Revised timerfd() interface
• Previous by thread: Re: [PATCH -mm 2/2] 3c59x MAINTAINERS
• Next by thread: Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]