Re: bug in 2.6.22.6, net/sunrpc/svcsock.c

[Satyam Sharma <satyam@infradead.org>]

Hi Wolfgang,


On Mon, 3 Sep 2007, Wolfgang Walter wrote:
> 
> in 2.6.22.6, net/sunrpc/svcsock.c
> 
> random characters are printed by svc_tcp_accept:
> 
> 	lockd: last TCP connect from <some random chars>
> [...]
> 
> --- linux-2.6.22.6/net/sunrpc/svcsock.c	2007-08-27 18:10:14.000000000 +0200
> +++ linux-2.6.22.6w/net/sunrpc/svcsock.c	2007-09-03 18:27:30.000000000 +0200
> @@ -1090,7 +1090,7 @@
>  						   serv->sv_name);
>  				printk(KERN_NOTICE
>  				       "%s: last TCP connect from %s\n",
> -				       serv->sv_name, buf);
> +				       serv->sv_name, __svc_print_addr(sin, buf, sizeof(buf)));
>  			}
>  			/*
>  			 * Always select the oldest socket. It's not fair,

Your patch is correct, but please read patch submission instructions at:

http://lxr.linux.no/source/Documentation/SubmittingPatches
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
http://lkml.org/lkml/2005/4/7/183

At a minimum, you need to: (1) provide Signed-off-by: line on top of the
patch, (2) cc: netdev[at]vger.kernel.org (or other maintainer(s)) in your
mail, and, (3) give a useful "[patch] sunrpc: fix printk argument" kind of
Subject: line.


Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/