Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

[Jan Engelhardt <jengelh@computergmbh.de>]

On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote:
>@@ -184,10 +183,92 @@ out:
> }
> 
> /*
>+ * Determine if the lower inode objects have changed from below the unionfs
>+ * inode.  Return 1 if changed, 0 otherwise.
>+ */
>+int is_newer_lower(const struct dentry *dentry)

Could use bool and true/false as return value.

>-int __unionfs_d_revalidate_chain(struct dentry *dentry, struct nameidata *nd)
>+int __unionfs_d_revalidate_chain(struct dentry *dentry, struct nameidata *nd,
>+				 int willwrite)

also looks like a bool (willwrite)

>-	if (!__unionfs_d_revalidate_chain(dentry, NULL)) {
>+	if (!__unionfs_d_revalidate_chain(dentry, NULL, 0)) {

(Are there any callers with ,1?)



	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/