[PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

drivers/scsi/ips.c: In function ‘ips_register_scsi’:
drivers/scsi/ips.c:6869:
warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result

scsi_add_host() is __must_check, so let's check it's return and cleanup
appropriately on errors.

Signed-off-by: Satyam Sharma <[email protected]>

---

 drivers/scsi/ips.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1/drivers/scsi/ips.c~fix	2007-09-02 20:21:27.000000000 +0530
+++ linux-2.6.23-rc4-mm1/drivers/scsi/ips.c	2007-09-02 20:25:58.000000000 +0530
@@ -6866,7 +6866,12 @@ ips_register_scsi(int index)
 	sh->max_channel = ha->nbus - 1;
 	sh->can_queue = ha->max_cmds - 1;
 
-	scsi_add_host(sh, NULL);
+	if (scsi_add_host(sh, NULL)) {
+		IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host\n");
+		free_irq(ha->irq, ha);
+		scsi_host_put(sh);
+		return -1;
+	}
 	scsi_scan_host(sh);
 
 	return 0;

---

• Follow-Ups:
  • Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()
    • From: Jesper Juhl <[email protected]>

• References:
  • [-mm patchset] War on warnings
    • From: Satyam Sharma <[email protected]>

• Prev by Date: Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.
• Next by Date: [PATCH -mm] sb16: Shut up uninitialized var build warning
• Previous by thread: [PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible pointer type warning
• Next by thread: Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]