Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2)

[Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>]

Andrew Morton wrote:
> > On Sat, 01 Sep 2007 17:04:06 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> > Andrew Morton wrote:
> >     
> > > On Fri, 24 Aug 2007 15:26:57 -0700 travis@sgi.com wrote:
> > >
> > >   
> > >       
> > > > Convert cpu_sibling_map from a static array sized by NR_CPUS to a
> > > > per_cpu variable.  This saves sizeof(cpumask_t) * NR unused cpus.
> > > > Access is mostly from startup and CPU HOTPLUG functions.
> > > >     
> > > >         
> > > ia64 allmodconfig:
> > >
> > > kernel/sched.c: In function `cpu_to_phys_group':                                                                             kernel/sched.c:5937: error: `per_cpu__cpu_sibling_map' undeclared (first use in this function)                               kernel/sched.c:5937: error: (Each undeclared identifier is reported only once
> > > kernel/sched.c:5937: error: for each function it appears in.)                                                                kernel/sched.c:5937: warning: type defaults to `int' in declaration of `type name'
> > > kernel/sched.c:5937: error: invalid type argument of `unary *'                                                               kernel/sched.c: In function `build_sched_domains':                                                                           kernel/sched.c:6172: error: `per_cpu__cpu_sibling_map' undeclared (first use in this function)                               kernel/sched.c:6172: warning: type defaults to `int' in declaration of `type name'                                           kernel/sched.c:6172: error: invalid type argument of `unary *'                                                               kernel/sched.c:6183: warning: type defaults to `int' in declaration of `type name'                                           kernel/sched.c:6183: error: invalid type argument of `unary *'                                                               
> > > -
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at  http://www.tux.org/lkml/
> > >
> > >
> > >   
> > >       
> > Hi Andrew,
> >
> > I get the exact build failure on ppc64 machine with 2.6.23-rc4-mm1.
> >
> >     
>
> The ia64 workaround was to disable SCHED_SMT.
>   
Hi Andrew,

Same workaround works with ppc64 also.

Thanks & Regards,
Kamalesh Babulal.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/