Re: [PATCH 1/3] netlink: use the macro min(x,y) provided by <linux/kernel.h> instead

On 9/2/07, David Newall <[email protected]> wrote:
> Denis Cheng wrote
> > +     order = get_bitmask_order(min(max, (unsigned long)UINT_MAX)) - 1;
> >
>
> Why doesn't this clash with the max define, also in linux/kernel.h?
They indeed don't clash,
the cpp included by gcc is intelligent enough, it know the
function-style definition of max in kernel.h, that's different from
the auto variable max here, so they don't clash with each other,

But I think the variable name "max" here is ambiguous, I changed it to
"limit", see my following patch [PATCH 2/3].

-- 
Denis Cheng
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/3] netlink: use the macro min(x,y) provided by <linux/kernel.h> instead
    • From: Denis Cheng <[email protected]>

• Prev by Date: Re: Fwd: That whole "Linux stealing our code" thing
• Next by Date: Re: recent nfs change causes autofs regression
• Previous by thread: Re: [PATCH 2/3] netlink: the temp variable name max is ambiguous
• Next by thread: Re: [PATCH 1/3] netlink: use the macro min(x,y) provided by <linux/kernel.h> instead
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]