Grant Grundler wrote:
On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
Signed-off-by: ?Jason Gaston <[email protected]>
--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
-0700
+++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
@@ -550,6 +550,7 @@
case PCI_DEVICE_ID_INTEL_ICH9_3:
case PCI_DEVICE_ID_INTEL_ICH9_4:
case PCI_DEVICE_ID_INTEL_ICH9_5:
+ case PCI_DEVICE_ID_INTEL_Tolapai_0:
If this is the only place it's used, the prefence is to define the
constant locally (in the file) and not in pci_ids.h.
Kinda sorta: if you must define a constant, it should go into
linux/pci_ids.h. Otherwise someone will come along later, do the same
locally in another file, then you have two independent symbols with the
same meaning.
Ideally, in pci_device_id tables and such, you can just use the hex
number, since they are all arbitrary and lack meaning anyway.
Please do submit new PCI device IDs to pciids.sf.net project.
Yep.
#define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
#define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
#define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
And change the StudlyCaps to ALLCAPS.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
