Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

Jesper Juhl wrote:

What would be wrong in applying my patch that removes the cast of the
kmalloc() return value and then also remove the "__nocast" here?

We use it as a safety measure when coding. For example the write register function takes an address and a value. We got one of these the wrong way round once, and had a non-obvious bug.

nocast and sparse helps us prevent this.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 01/30] ia64: Remove unnecessary cast of allocation return value in sn_hwperf_enum_objects()
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver
    • From: Daniel Drake <[email protected]>
  • Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver
    • From: "Jesper Juhl" <[email protected]>

• Prev by Date: RE: FC - NPIV in 2.6.23-rc2
• Next by Date: Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
• Previous by thread: Re: [PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver)
• Next by thread: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]