Re: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3

On Wed, 29 Aug 2007, Peter Lund wrote:

>  
> -	if (tmp >= RADIX_TREE_INDEX_BITS)
> -		index = ~0UL;
> -	return index;
> +	if (shift < 0)
> +		return ~0UL;
> +	if (shift >= 8 * sizeof(unsigned long))

8* sizeof(unsigned long) is the constant BITS_PER_LONG.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3
    • From: Björn Steinbrink <[email protected]>

• References:
  • [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3
    • From: Peter Lund <[email protected]>

• Prev by Date: Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc
• Next by Date: 2.6.22 oops kernel BUG at block/elevator.c:366!
• Previous by thread: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3
• Next by thread: Re: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]