Re: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3

[Christoph Lameter <clameter@sgi.com>]

On Wed, 29 Aug 2007, Peter Lund wrote:

>  
> -	if (tmp >= RADIX_TREE_INDEX_BITS)
> -		index = ~0UL;
> -	return index;
> +	if (shift < 0)
> +		return ~0UL;
> +	if (shift >= 8 * sizeof(unsigned long))

8* sizeof(unsigned long) is the constant BITS_PER_LONG.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/