Re: [PATCH] Send quota messages via netlink

On Tue, 28 Aug 2007 16:13:18 +0200 Jan Kara <[email protected]> wrote:

> +static void send_warning(const struct dquot *dquot, const char warntype)
> +{
> +	static unsigned long seq;
> +	struct sk_buff *skb;
> +	void *msg_head;
> +	int ret;
> +
> +	skb = genlmsg_new(QUOTA_NL_MSG_SIZE, GFP_NOFS);
> +	if (!skb) {
> +		printk(KERN_ERR
> +		  "VFS: Not enough memory to send quota warning.\n");
> +		return;
> +	}
> +	msg_head = genlmsg_put(skb, 0, seq++, &quota_genl_family, 0, QUOTA_NL_C_WARNING);

The access to seq is racy, isn't it?

If so, that can be solved with a lock, or with atomic_add_return().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Send quota messages via netlink
    • From: Jan Kara <[email protected]>
  • Re: [PATCH] Send quota messages via netlink
    • From: Jan Kara <[email protected]>

• References:
  • [PATCH] Send quota messages via netlink
    • From: Jan Kara <[email protected]>

• Prev by Date: Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.
• Next by Date: Re: CFS review
• Previous by thread: Re: [PATCH] Send quota messages via netlink
• Next by thread: Re: [PATCH] Send quota messages via netlink
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]