Re: [PATCH 5/5] Net: ath5k, kconfig changes

On Tue, Aug 28, 2007 at 12:01:30PM -0400, Jiri Slaby wrote:
> +config ATH5K_AR5210
> +	bool "Support AR5210"
> +	depends on ATH5K
> +	default y
> +
> +config ATH5K_AR5211
> +	bool "Support AR5211"
> +	depends on ATH5K
> +	default y
> +
> +config ATH5K_AR5212
> +	bool "Support AR5212"
> +	depends on ATH5K
> +	default y

Please don't add more default statements.

Also this whole patch seems rather pointless.  It saves only
very little and turns the driver into a complete ifdef maze.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 5/5] Net: ath5k, kconfig changes
  - From: "Nick Kossifidis" <[email protected]>

References:
- [PATCH 5/5] Net: ath5k, kconfig changes
  - From: Jiri Slaby <[email protected]>

Prev by Date: Re: [PATCH 4/5] Net: ath5k, license is GPLv2
Next by Date: Re: ok to kill "ether=" kernel parm?
Previous by thread: [PATCH 5/5] Net: ath5k, kconfig changes
Next by thread: Re: [PATCH 5/5] Net: ath5k, kconfig changes
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]