On Monday August 27, [email protected] wrote: > > +/* Reference counting, callback cleanup, etc., all look racy as heck. > + * And why is cb_set an atomic? */ Agreed.... so do we really want this code in mainline? is the old code so bad that this is better? - cb_set should not be atomic. - This looks like a job for async-rpc rather than a kernel thread - If you do use a thread, you at least want __module_get before starting the thread, and module_put_and_exit to terminate the thread. - Can you just use 'cb_client' rather than cb_set? If you move rpc_create into the thread, you don't need to set cb_client until the callback is successful. Then add a 'cb_active' flag bit so that you don't have two callbacks at the same time, and it should be less racy.. The other 14 patches all look ok. Thanks, NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 08/15] knfsd: spawn kernel thread to probe callback channel
- From: "J. Bruce Fields" <[email protected]>
- Re: [PATCH 08/15] knfsd: spawn kernel thread to probe callback channel
- References:
- nfs server patches for review
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 01/15] nfsd: tone down inaccurate dprintk
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 02/15] nfsd: remove unused cache_for_each macro
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 03/15] nfsd: fix horrible indentation in nfsd_setattr
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 04/15] knfsd: delete code made redundant by map_new_errors
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 05/15] knfsd: cleanup of nfsd4 cmp_* functions
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 06/15] knfsd: demote some printk()s to dprintk()s
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 07/15] knfsd: nfs4 name->id mapping not correctly parsing negative downcall
- From: "J. Bruce Fields" <[email protected]>
- [PATCH 08/15] knfsd: spawn kernel thread to probe callback channel
- From: "J. Bruce Fields" <[email protected]>
- nfs server patches for review
- Prev by Date: [PATCH] Fix tiny compiler warning in smount example program from Documentation/sharedsubtree.txt
- Next by Date: Re: [RFC] block_device_operations prototype changes
- Previous by thread: [PATCH 15/15] knfsd: 64 bit ino support for NFS server
- Next by thread: Re: [PATCH 08/15] knfsd: spawn kernel thread to probe callback channel
- Index(es):
 |