On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote: > The preferred way of doing this is via Kconfig, please. ie: add a > CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig. > It would be better to do something like this in (say) suspend.h: > > #ifdef CONFIG_HIBERNATION_HEADER > extern int arch_hibernation_header_save(void *addr, unsigned int max_size); > extern int arch_hibernation_header_restore(void *addr); > #else > static inline int arch_hibernation_header_save(void *addr, In fact, I guess we don't need to bother with this at all. The generic code for doing this (via the utsname based header) is tiny, so as far as I can tell it could just be made weak symbols (by this I mean init_header_complete() and check_image_kernel()), and then all the #ifdefs can just go. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
- From: "Rafael J. Wysocki" <[email protected]>
- Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
- References:
- [PATCH -mm 0/2] Hibernation: Arbitrary boot kernel support on x86_64
- From: "Rafael J. Wysocki" <[email protected]>
- [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
- From: "Rafael J. Wysocki" <[email protected]>
- Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
- From: Andrew Morton <[email protected]>
- [PATCH -mm 0/2] Hibernation: Arbitrary boot kernel support on x86_64
- Prev by Date: [RFC] block_device_operations prototype changes
- Next by Date: Re: CFS review
- Previous by thread: Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
- Next by thread: Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64
- Index(es):
 |